Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 )
Change subject: IMPALA-8444: Fix performance regression when building privilege name ...................................................................... Patch Set 6: Code-Review+1 (1 comment) I'll let Csaba take another pass. http://gerrit.cloudera.org:8080/#/c/13095/6/fe/src/main/java/org/apache/impala/catalog/Principal.java File fe/src/main/java/org/apache/impala/catalog/Principal.java: http://gerrit.cloudera.org:8080/#/c/13095/6/fe/src/main/java/org/apache/impala/catalog/Principal.java@82 PS6, Line 82: return principalPrivileges_.keySet(); Actually thinking again, we are at a risk of exposing the underlying keySet() to the callers who can change it (same above). Probably safer to to return an ImmutableSet<> (and ImmutableList<> above). Anyway, they only do a shallow copy, so that should be fine I guess. -- To view, visit http://gerrit.cloudera.org:8080/13095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942d9b55f07c8972f69e532567d9b7d80fceb6e5 Gerrit-Change-Number: 13095 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2019 21:57:59 +0000 Gerrit-HasComments: Yes
