Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13190 )
Change subject: IMPALA-8409: Fix row-size for STRING columns with unknown stats ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13190/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/13190/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@469 PS2, Line 469: // Note that this test used to be flaky, so it was removed (6 years ago). I added it Yeah I think we'd have noticed if stats were disappearing in our Jenkin's runs. Could just remove this comment. http://gerrit.cloudera.org:8080/#/c/13190/2/tests/metadata/test_explain.py File tests/metadata/test_explain.py: http://gerrit.cloudera.org:8080/#/c/13190/2/tests/metadata/test_explain.py@141 PS2, Line 141: def test_explain_row_size_estimates(self, vector, unique_database): My initial reaction was that this should be a planner test. I can see, though, that there's some value in having an end-to-end test like this since it does actually test that the stats are handled correctly end-to-end from compute stats to the planner. Can you add a sentence to the method comment to justify why this should be an end-to-end test. We don't want future people blindly copying this instead of writing a planner test. http://gerrit.cloudera.org:8080/#/c/13190/2/tests/metadata/test_explain.py@142 PS2, Line 142: # Tests that EXPLAIN returns the expected row sizes with and without stats. Should use a """ """ docstring for method comments -- To view, visit http://gerrit.cloudera.org:8080/13190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I866acf10b2c011a735dee019f4bc29358f2ec4e5 Gerrit-Change-Number: 13190 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 16:02:09 +0000 Gerrit-HasComments: Yes
