Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13190 )
Change subject: IMPALA-8409: Fix row-size for STRING columns with unknown stats ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13190/4/tests/metadata/test_explain.py File tests/metadata/test_explain.py: http://gerrit.cloudera.org:8080/#/c/13190/4/tests/metadata/test_explain.py@87 PS4, Line 87: assert found_match Can you make sure these asserts print the output with the missing string? Makes it easier to debug if it fails in future. assert found_match, query_result -- To view, visit http://gerrit.cloudera.org:8080/13190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I866acf10b2c011a735dee019f4bc29358f2ec4e5 Gerrit-Change-Number: 13190 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2019 17:35:18 +0000 Gerrit-HasComments: Yes
