Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13113 )

Change subject: Verify existence of HIVE_AUX_JARS before running HS2
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13113/1/testdata/bin/run-hive-server.sh
File testdata/bin/run-hive-server.sh:

http://gerrit.cloudera.org:8080/#/c/13113/1/testdata/bin/run-hive-server.sh@47
PS1, Line 47: IFS=: read -r -a aux_jars <<< "$HIVE_AUX_JARS_PATH"
            : for jar in "${aux_jars[@]}"; do
            :   if [[ "$jar" == *.jar ]] && ! test -f $jar ; then
            :     echo "JAR $jar listed in \$HIVE_AUX_JARS_PATH does not exist."
            :     echo "You may need to build the fe or run mvn 
dependencies:copy-dependencies"
            :     exit 1
            :   fi
            : done
This solution works but I was curious to see why the hive scripts don't do this 
check and I found this $HIVE_HOME/bin/hive

# add the auxillary jars such as serdes
if [ -d "${HIVE_AUX_JARS_PATH}" ]; then
  hive_aux_jars_abspath=`cd ${HIVE_AUX_JARS_PATH} && pwd`
  for f in $hive_aux_jars_abspath/*.jar; do
    if [[ ! -f $f ]]; then
        continue;
    fi
    if $cygwin; then
        f=`cygpath -w "$f"`
    fi
    AUX_CLASSPATH=${AUX_CLASSPATH}:$f
    if [ "${AUX_PARAM}" == "" ]; then
        AUX_PARAM=file://$f
    else
        AUX_PARAM=${AUX_PARAM},file://$f;
    fi
  done
elif [ "${HIVE_AUX_JARS_PATH}" != "" ]; then
  HIVE_AUX_JARS_PATH=`echo $HIVE_AUX_JARS_PATH | sed 's/,/:/g'`
  if $cygwin; then
      HIVE_AUX_JARS_PATH=`cygpath -p -w "$HIVE_AUX_JARS_PATH"`
      HIVE_AUX_JARS_PATH=`echo $HIVE_AUX_JARS_PATH | sed 's/;/,/g'`
  fi
  AUX_CLASSPATH=${AUX_CLASSPATH}:${HIVE_AUX_JARS_PATH}
  AUX_PARAM="file://$(echo ${HIVE_AUX_JARS_PATH} | sed 's/:/,file:\/\//g')"
fi

My understanding (confirmed with hive docs) the database driver jars which are 
essential for metastore should be soft linked to $HIVE_HOME/lib directory 
instead of adding it to aux_jar_path. Perhaps a easier way to fix this would to 
be do that instead of adding it in the aux_jar_path in impala-config.sh



--
To view, visit http://gerrit.cloudera.org:8080/13113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2458b9e92a9243fc00d1bd80791062c89496f7
Gerrit-Change-Number: 13113
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Tue, 30 Apr 2019 18:30:48 +0000
Gerrit-HasComments: Yes

Reply via email to