Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13113 )
Change subject: Verify existence of HIVE_AUX_JARS before running HS2 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13113/1/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/13113/1/testdata/bin/run-hive-server.sh@47 PS1, Line 47: IFS=: read -r -a aux_jars <<< "$HIVE_AUX_JARS_PATH" : for jar in "${aux_jars[@]}"; do : if [[ "$jar" == *.jar ]] && ! test -f $jar ; then : echo "JAR $jar listed in \$HIVE_AUX_JARS_PATH does not exist." : echo "You may need to build the fe or run mvn dependencies:copy-dependencies" : exit 1 : fi : done > This solution works but I was curious to see why the hive scripts don't do I don't think we should be symlinking stuff into the hive bin dir, because we generally want to treat the thirdparty downloaded artifacts as "read only". Otherwise we may start to accumulate state in that directory which may need to be changed over as you switch build configs, etc. I think it would be worth considering passing the postgres jar with some other method, though -- eg a HADOOP_CLASSPATH entry etc -- To view, visit http://gerrit.cloudera.org:8080/13113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a2458b9e92a9243fc00d1bd80791062c89496f7 Gerrit-Change-Number: 13113 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 19:58:09 +0000 Gerrit-HasComments: Yes
