Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13122 )
Change subject: IMPALA-8121: part 1: some test fixes for catalog v2 ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_compute_stats.py@166 PS11, Line 166: stats_pulling_disabled hmm, I'm trying to remember what's going on here. With local catalog, don't we do the same thing where we don't fetch incremental stats with the normal partition object, but pull them separately? Is there an unexpected bug here? http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_refresh_partition.py File tests/metadata/test_refresh_partition.py: http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_refresh_partition.py@139 PS11, Line 139: # HMS notifications may pick up added partition racily. do HMS notifications _only_ run in catalog v2? I thought the notifications run in either case, so this would be racy in v1 as well, just less likely to race because it's only propagated once every two seconds? -- To view, visit http://gerrit.cloudera.org:8080/13122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I060f2076da74fbbe92ae26dbad51f09a3bd20169 Gerrit-Change-Number: 13122 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2019 18:32:47 +0000 Gerrit-HasComments: Yes
