Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13122 )
Change subject: IMPALA-8121: part 1: some test fixes for catalog v2 ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_compute_stats.py@166 PS11, Line 166: stats_pulling_disabled > hmm, I'm trying to remember what's going on here. With local catalog, don't Maybe you get the incremental pulling behaviour as a side-effect with the local catalog instead of as a special optimisation. It's definitely deliberate. // TODO(vercegovac): add validation to ensure that both pulling incremental // statistics and a local catalog are not specified. throw new UnsupportedOperationException("--pull_incremental_statistics and " + "--use_local_catalog cannot both be enabled." ); http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_refresh_partition.py File tests/metadata/test_refresh_partition.py: http://gerrit.cloudera.org:8080/#/c/13122/11/tests/metadata/test_refresh_partition.py@139 PS11, Line 139: # HMS notifications may pick up added partition racily. > do HMS notifications _only_ run in catalog v2? I thought the notifications I'm assuming that we're either running tests with all the new catalog stuff enabled or all of it disabled. I haven't bothered to fix things for other parts of the matrix (i.e. hms notifications enabled with the non-local catalog). -- To view, visit http://gerrit.cloudera.org:8080/13122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I060f2076da74fbbe92ae26dbad51f09a3bd20169 Gerrit-Change-Number: 13122 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2019 20:33:46 +0000 Gerrit-HasComments: Yes
