Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13219 )
Change subject: Fix redundant downloads of hive source tarball ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13219/3/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13219/3/bin/bootstrap_toolchain.py@453 PS3, Line 453: if component.pkg_directory is not None: nit: maybe move this to the constructor? seems easier to reason about http://gerrit.cloudera.org:8080/#/c/13219/3/bin/bootstrap_toolchain.py@579 PS3, Line 579: "hive-{0}-source" : .format(hive_version), pkg_directory="hive-{0}" : .format(hive_version nit: might be more readable to re-flow this so that the "".format() calls are not broken across lines -- To view, visit http://gerrit.cloudera.org:8080/13219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd04a1a367a0cc4aa0a2b490a45fbc93a862c83a Gerrit-Change-Number: 13219 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2019 05:41:28 +0000 Gerrit-HasComments: Yes
