Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13219 )
Change subject: Fix redundant downloads of hive source tarball ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13219/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13219/4//COMMIT_MSG@13 PS4, Line 13: Due to : this > nit: repeated use of "due to this", we can just use "and" Done http://gerrit.cloudera.org:8080/#/c/13219/4/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13219/4/bin/bootstrap_toolchain.py@121 PS4, Line 121: component package directory" > nit: fix indentation Not sure how to fix this without adding more spaces in the exception message. http://gerrit.cloudera.org:8080/#/c/13219/4/bin/bootstrap_toolchain.py@122 PS4, Line 122: if pkg_directory is not None: : self.pkg_directory = "{0}/{1}".format(cdp_components_home, pkg_directory) : else: : self.pkg_directory = "{0}/{1}".format(cdp_components_home, basename) > It's more Pythonic to do this: Done -- To view, visit http://gerrit.cloudera.org:8080/13219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd04a1a367a0cc4aa0a2b490a45fbc93a862c83a Gerrit-Change-Number: 13219 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 03 May 2019 20:37:58 +0000 Gerrit-HasComments: Yes
