Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 )
Change subject: Hive 3: switch to Tez-on-YARN execution ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13224/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13224/1/bin/bootstrap_toolchain.py@571 PS1, Line 571: use_cdp_hive looks like we can get rid of this line since it is already initialized above. http://gerrit.cloudera.org:8080/#/c/13224/1/testdata/cluster/admin File testdata/cluster/admin: http://gerrit.cloudera.org:8080/#/c/13224/1/testdata/cluster/admin@311 PS1, Line 311: for would be great if you could add a comment here explain why this is being done. -- To view, visit http://gerrit.cloudera.org:8080/13224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96064f271582b2790a3cfb3d135f3834d46c41d Gerrit-Change-Number: 13224 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2019 18:01:15 +0000 Gerrit-HasComments: Yes
