Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 )
Change subject: Hive 3: switch to Tez-on-YARN execution ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/13224/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13224/1/bin/bootstrap_toolchain.py@571 PS1, Line 571: use_cdp_hive > looks like we can get rid of this line since it is already initialized abov Done http://gerrit.cloudera.org:8080/#/c/13224/1/bin/generate_xml_config.py File bin/generate_xml_config.py: http://gerrit.cloudera.org:8080/#/c/13224/1/bin/generate_xml_config.py@105 PS1, Line 105: e > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/13224/1/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/13224/1/fe/src/test/resources/hive-site.xml.py@86 PS1, Line 86: > flake8: E202 whitespace before '}' Done http://gerrit.cloudera.org:8080/#/c/13224/1/testdata/cluster/admin File testdata/cluster/admin: http://gerrit.cloudera.org:8080/#/c/13224/1/testdata/cluster/admin@311 PS1, Line 311: for > would be great if you could add a comment here explain why this is being do Done http://gerrit.cloudera.org:8080/#/c/13224/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py File testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py: PS1: ignoring the line length warnings here since it's not really code and I think wrapping will just make it harder to read http://gerrit.cloudera.org:8080/#/c/13224/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py@57 PS1, Line 57: } > flake8: E123 closing bracket does not match indentation of opening bracket' Done -- To view, visit http://gerrit.cloudera.org:8080/13224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96064f271582b2790a3cfb3d135f3834d46c41d Gerrit-Change-Number: 13224 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 03 May 2019 18:23:04 +0000 Gerrit-HasComments: Yes
