Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 )
Change subject: IMPALA-8438: Store WriteId and valid writeId list for table and partitio ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/13215/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13215/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-8438: Store WriteId and valid writeId list for table and partitio nit: missing n http://gerrit.cloudera.org:8080/#/c/13215/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13215/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-8438: Store WriteId and valid writeId list for table and partitio nit: missing n http://gerrit.cloudera.org:8080/#/c/13215/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/13215/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@233 PS5, Line 233: // ToDo this assumes the acid tables have been created. : // They will be available after IMPALA-8439 is checked in. : testLoadAcidTables("select * from acid.insert_only_no_partitions"); : testLoadAcidTables("select * from acid.insert_only_with_partitions"); These tables should have deterministic writeIds, so the test could except a given validWriteIds string. -- To view, visit http://gerrit.cloudera.org:8080/13215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6edbd64424edf0ba88af110ab8b958a1966b8b54 Gerrit-Change-Number: 13215 Gerrit-PatchSet: 5 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2019 21:11:43 +0000 Gerrit-HasComments: Yes
