Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 )
Change subject: IMPALA-8438: Store WriteId and valid writeId list for table and partitio ...................................................................... Patch Set 5: (7 comments) Thanks for your reviews. submit patch 6 http://gerrit.cloudera.org:8080/#/c/13215/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13215/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-8438: Store WriteId and valid writeId list for table and partitio > nit: missing n Done http://gerrit.cloudera.org:8080/#/c/13215/3//COMMIT_MSG@10 PS3, Line 10: fucntions > nit, spell-check Done http://gerrit.cloudera.org:8080/#/c/13215/3/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/13215/3/common/thrift/CatalogObjects.thrift@483 PS3, Line 483: 4: optional string valid_write_ids > Instead of storing this in string format, do you think it would be better t Keep the formatted String we can easily use hive provided functions to convert and use it. http://gerrit.cloudera.org:8080/#/c/13215/3/fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/13215/3/fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java@237 PS3, Line 237: getHighestWriteId > Do you think its better to throw UnsupportedOperationException in these met One of the reason of adding these functions is to avoid run time exceptions for Hive 2 client, it will be convert to these values when catch UnSupportedException anyway. http://gerrit.cloudera.org:8080/#/c/13215/3/fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java@258 PS3, Line 258: public static long getMajorVersion() { > +1 Done http://gerrit.cloudera.org:8080/#/c/13215/4/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/13215/4/fe/src/main/java/org/apache/impala/catalog/Table.java@281 PS4, Line 281: String tblFullName = getFullName(); > tab used for whitespace Done http://gerrit.cloudera.org:8080/#/c/13215/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/13215/5/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@233 PS5, Line 233: // ToDo this assumes the acid tables have been created. : // They will be available after IMPALA-8439 is checked in. : testLoadAcidTables("select * from acid.insert_only_no_partitions"); : testLoadAcidTables("select * from acid.insert_only_with_partitions"); > These tables should have deterministic writeIds, so the test could except a The major purpose of the test is to test we can get writeIds from hive. We do not test the correctness of hive code. And I think the writeid list could be very dynamic which can cause flaky tests. -- To view, visit http://gerrit.cloudera.org:8080/13215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6edbd64424edf0ba88af110ab8b958a1966b8b54 Gerrit-Change-Number: 13215 Gerrit-PatchSet: 5 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 03 May 2019 21:35:30 +0000 Gerrit-HasComments: Yes
