Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13242 )
Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13242/2/testdata/workloads/functional-query/queries/QueryTest/data-cache.test File testdata/workloads/functional-query/queries/QueryTest/data-cache.test: http://gerrit.cloudera.org:8080/#/c/13242/2/testdata/workloads/functional-query/queries/QueryTest/data-cache.test@41 PS2, Line 41: # Verifies that stale data from the cache is not used. > nit: . instead of ; Done http://gerrit.cloudera.org:8080/#/c/13242/2/tests/custom_cluster/test_data_cache.py File tests/custom_cluster/test_data_cache.py: http://gerrit.cloudera.org:8080/#/c/13242/2/tests/custom_cluster/test_data_cache.py@39 PS2, Line 39: cache_force_single_shard > Should we have a second test without that flag that just checks that the hi I added a second test which only checks the metrics but not the counters in the profile. Seems a bit tricky to support both cases in data-cache.test unless we loosen the checks. -- To view, visit http://gerrit.cloudera.org:8080/13242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98d5b8fa1d3fb25682a64bffaf56d751a140e4c9 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Sat, 04 May 2019 17:56:00 +0000 Gerrit-HasComments: Yes
