Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13242 )
Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py ...................................................................... Patch Set 4: Code-Review+2 (3 comments) Carry Lars' +2. http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py File tests/custom_cluster/test_data_cache.py: http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py@58 PS3, Line 58: t count m > ...verifies that the cache hit count metrics are correct. Done http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py@59 PS3, Line 59: es hit is > "The exact number of bytes.." Done http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py@63 PS3, Line 63: warm up the cache. Expect no hits. > make the query a variable? Done -- To view, visit http://gerrit.cloudera.org:8080/13242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98d5b8fa1d3fb25682a64bffaf56d751a140e4c9 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Sat, 04 May 2019 20:48:56 +0000 Gerrit-HasComments: Yes
