Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py@1628 PS1, Line 1628: test_global_config = os.path.expanduser(options.global_config) : if os.path.isfile(test_global_config) and test_global_config != default_global_config: : default_global_config = test_global_config : elif test_global_config != default_global_config: : print_to_stderr('%s not found.\n' % test_global_config) : sys.exit(1) : : # use path to custom file specified by user in config_file option : input_config = os.path.expanduser(options.config_file) : # verify input_config, if found : if os.path.isfile(input_config) and input_config != default_user_config: : if options.verbose: : print_to_stderr("Loading in options from config file: %s \n" % input_config) : # command line overrides loading ~/.impalarc : default_user_config = input_config : elif input_config != default_user_config: : print_to_stderr('%s not found.\n' % input_config) : sys.exit(1) : : configs_to_lo > The logic here is difficult to follow. I believe this is basically what we Thanks for the heads up. I tried my best to make it more readable. It does look somewhat more complex then it should due to the prints and error checking. -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 2 Gerrit-Owner: Ethan Xue <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Ethan Xue <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 20:44:19 +0000 Gerrit-HasComments: Yes
