Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13313/1/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/13313/1/shell/option_parser.py@260 PS1, Line 260: help=SUPPRESS_HELP > One potential use case that maybe useful is is to specify a different locat This is one of the ways we thought of while coming up with this solution, so I am completely on board if you think this use case will be common. The only reason I am usually skeptical about adding env variables is that, if you are sourcing a bunch of them in and the naming is ambiguous then there can be some conflicting ones and it can get difficult to manage. We will have to be super careful about naming this so its super obvious what it is used for, how about IMPALA_SHELL_GLOBAL_CONFIG_FILE. Also if we want users to set this then we might want to expose this somewhere in the help text and make sure we update the impala docs. -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 4 Gerrit-Owner: Ethan Xue <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Ethan Xue <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 16 May 2019 19:56:08 +0000 Gerrit-HasComments: Yes
