Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 )
Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading ...................................................................... Patch Set 4: Code-Review+2 (1 comment) This looks good to me. http://gerrit.cloudera.org:8080/#/c/13251/4/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/13251/4/testdata/datasets/functional/functional_schema_template.sql@2578 PS4, Line 2578: CREATE_HIVE > ah. Got it. That said, I think it's fine, because we aren't actually trying Yeah, that seems fine. We literally can't use hive_index for anything, so it seems harmless for it to be empty. -- To view, visit http://gerrit.cloudera.org:8080/13251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34930dc064da3136dde4e01a011d14db6a74ecd Gerrit-Change-Number: 13251 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 00:49:23 +0000 Gerrit-HasComments: Yes
