Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 )
Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading ...................................................................... Patch Set 3: (2 comments) Forgot to post this earlier http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/README File testdata/datasets/README: http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/README@69 PS2, Line 69: INSERT/SELECT * - The INSERT/SELECT * command for loading from the base table LOAD is the command used for loading the text version of the table. It is usually a LOAD DATA statement. http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/functional/functional_schema_template.sql@2572 PS2, Line 2572: ---- DATASET : functional : ---- BASE_TABLE_NAME : hive_index : ---- VERSION_REQUIREMENTS : hive < 3.0 : ---- CREATE_HIVE : DROP INDEX IF EXISTS hive_index ON {db_name}{db_suffix}.alltypes; : CREATE INDEX hive_index ON TABLE {db_name}{db_suffix}.alltypes (int_col) : AS 'org.apache.hadoop.hive.ql.index.compact.CompactIndexHandler' : WITH DEFERRED REBUILD IN TABLE {db_name}{db_suffix}.hive_index_tbl; I think we only need the functional.hive_index version of this, so let's add this to testdata/datasets/functional/schema_constraints.csv to restrict it to text/none/none. Then, this DEPENDENT_LOAD_HIVE becomes a LOAD section (which is executed by Hive). -- To view, visit http://gerrit.cloudera.org:8080/13251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34930dc064da3136dde4e01a011d14db6a74ecd Gerrit-Change-Number: 13251 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 15:32:19 +0000 Gerrit-HasComments: Yes
