Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13300 )
Change subject: IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@135 PS1, Line 135: notifications > should it be "notification events"? Done http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@146 PS1, Line 146: <codeph>ADD</codeph>, or <codeph>DROP</codeph> their : partitions > After IMPALA-7973, the add, drop and alter partition events trigger a refre Done http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@161 PS1, Line 161: Refreshes > I think may be we should also mention that if the table is not loaded, the Done. Do you mean if the table is not loaded because INSERT failed or no row was inserted? http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@198 PS1, Line 198: non-zero > may be say positive value to be accurate. Non-zero implies negative values Changed to "positive integer" http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@208 PS1, Line 208: such as adding new data to existing : tables/partitions from Spark > I think this is a very generic statement which may cause users to avoid usi Ok, will expand in a separate patch. Leaving this here for now, http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@221 PS1, Line 221: dump data directly > I think a better way to say this would be ".. and add or remove data into t Done http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@233 PS1, Line 233: Inserts into tables from Hive are ignored. > This can be misinterpreted as insert from Hive is not supported. I think in Removed the line http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@237 PS1, Line 237: invalidate > invalidated. Also, I think this is a implementation detail which do not nee Removed. http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@242 PS1, Line 242: Unlike other types of events, inserts by Impala triggers table refresh > This can be removed. I think its implementation detail and users may not ge Removed http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@267 PS1, Line 267: org.apache.hive.hcatalog.listener.DbNotificationListener > After IMPALA-7971, we also need hive.metastore.dml.events set to true Done -- To view, visit http://gerrit.cloudera.org:8080/13300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68133b0beeb15cacc73829b8a8b0838fc7f4b7d8 Gerrit-Change-Number: 13300 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 16 May 2019 01:07:33 +0000 Gerrit-HasComments: Yes
