Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13300 )
Change subject: IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation ...................................................................... Patch Set 2: (7 comments) Took another pass and suggested some changes. I think its good to go once these changes are made. Thanks! http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@161 PS1, Line 161: li> > Done. Do you mean if the table is not loaded because INSERT failed or no ro I mean if the table is not loaded and data was inserted using INSERT sql from Hive (or another Impala cluster), then Event processor does not refresh it. http://gerrit.cloudera.org:8080/#/c/13300/1/docs/topics/impala_metadata.xml@208 PS1, Line 208: : <p> > Ok, will expand in a separate patch. Leaving this here for now, Thanks http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@145 PS2, Line 145: events or Do we need "or" here? nit, event instead of events http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@219 PS2, Line 219: <li> : Adding data from one Impala cluster to existing tables/partitions is not synced to : another Impala cluster. : <p> : Only new tables and partitions are synced. : </p> : </li> This is not true anymore and can be removed http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@233 PS2, Line 233: recommend nit, recommended http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@233 PS2, Line 233: Hive's I think even Impala has a LOAD DATA command so we probably should mention that as well http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@263 PS2, Line 263: hive.metastore.dml.events This particular config should be present in the HiveServer2's configuration as well as Metastore service's hive-site.xml. So may be say this configuration key should be set to true in Hive service's (HiveServer2 and Hive Metastore) hive-site.xml -- To view, visit http://gerrit.cloudera.org:8080/13300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68133b0beeb15cacc73829b8a8b0838fc7f4b7d8 Gerrit-Change-Number: 13300 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Bharath Krishna <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Sat, 18 May 2019 04:07:26 +0000 Gerrit-HasComments: Yes
