Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-8503: add option to start Kudu cluster with HMS integration Like I said before, its difficult to evaluate this patch without seeing how it would actually be used. Especially now that its so short, I think you would be better off just merging it with the other patch you have out that uses this functionality http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master File testdata/cluster/node_templates/common/etc/init.d/kudu-master: http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master@28 PS3, Line 28: if [[ -n "$ENABLE_KUDU_HMS_INTEGRATION" ]]; then I think its better if this is more generic, eg. call the env variable IMPALA_KUDU_STARTUP_FLAGS and then when you want to enable HMS integration you can set that to the '-hive_metastore_uris=...' value. That way in the future other people can take advantage of it for other tests. -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Fri, 17 May 2019 16:45:32 +0000 Gerrit-HasComments: Yes
