Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin File testdata/cluster/admin: http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@497 PS1, Line 497: function restart { : if [[ $# -ne 1 ]]; then : echo restart must be called with a single argument -- the service to restart. 1>&2 : exit 1 : fi : local SERVICE=$1 : stop $SERVICE : start $SERVICE : } : : function delete_data { : # Delete namenode, datanode and KMS data while preserving directory structure. : rm -rf "$NODES_DIR/$NODE_PREFIX"*/data/dfs/{nn,dn}/* : rm -f "$NODES_DIR/$NODE_PREFIX"*/data/kms.keystore : delete_kudu_data : } > Yeah, I verified. What is the confusing point? The confusing piece for me was that restart_with_arg() could take an additional argument, but restart() doesn't seem to propagate it. Basically, I could not find where restart_with_arg() is used with two arguments. -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Tue, 21 May 2019 18:45:06 +0000 Gerrit-HasComments: Yes
