Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13313/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13313/6//COMMIT_MSG@9 PS6, Line 9: Currently, impalarc files can be specified on a per-user basis : (stored in ~/.impalarc), and they aren't created by default. The : Impala shell should pick up /etc/impalarc as well, in addition : to the user-specific configurations. mention the IMPALA_SHELL_GLOBAL_CONFIG_FILE here. http://gerrit.cloudera.org:8080/#/c/13313/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/13313/6/shell/impala_shell.py@159 PS6, Line 159: GLOBAL_CONFIG_DEFAULT_PATH = "/etc/impalarc" i believe we still can define the default here: https://github.com/apache/impala/blob/master/shell/impala_shell_config_defaults.py My understanding is impala_shell_config_defaults contains all the default values (not just default argument values) -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 6 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 17 May 2019 21:53:33 +0000 Gerrit-HasComments: Yes
