Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13382
to look at the new patch set (#2).
Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting
NDVs in local-catalog mode
......................................................................
IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in
local-catalog mode
This removes an old workaround in which columns with numDVs=-1 were
skipped when sending stats from catalogd to impalad. This workaround was
trying to fix some weird behavior with boolean stats but broke other
things, as noted in the JIRA. Additionally, it was used as a way to
avoid sending stats on clustering columns (which don't have computed
stats).
This change changes the workaround to be a bit more careful: we
explicitly ignore clustering columns, and for booleans, we use the
numNulls instead of numDVs to determine whether we have enough
information to infer numDVs.
While I was in this section of the code, I stumbled upon IMPALA-8215, a
bug in which the 'numTrues' of boolean columns was getting set to '1'
for no apparent reason. I fixed that while I was in the area.
Change-Id: Ic0b95de22954c7ad6715143fc42a1506289c095f
---
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M tests/common/skip.py
M tests/metadata/test_ddl.py
6 files changed, 24 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/13382/2
--
To view, visit http://gerrit.cloudera.org:8080/13382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0b95de22954c7ad6715143fc42a1506289c095f
Gerrit-Change-Number: 13382
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
