Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13382 )

Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting 
NDVs in local-catalog mode
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13382/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java:

http://gerrit.cloudera.org:8080/#/c/13382/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@284
PS1, Line 284:         colStatsData.setBooleanStats(new BooleanColumnStatsData(
> Maybe add reference to IMPALA-8205 while we're here.
Done


http://gerrit.cloudera.org:8080/#/c/13382/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@285
PS1, Line 285:             /*numTrues=*/-1, /*numFalse=*/-1, numNulls));
> Looks like you fixed IMPALA-8215, so you could include thatin the commit me
Done



--
To view, visit http://gerrit.cloudera.org:8080/13382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b95de22954c7ad6715143fc42a1506289c095f
Gerrit-Change-Number: 13382
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Tue, 21 May 2019 04:45:05 +0000
Gerrit-HasComments: Yes

Reply via email to