Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13300 )
Change subject: IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@145 PS2, Line 145: events or > Do we need "or" here? Done http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@219 PS2, Line 219: <li> : Adding data from one Impala cluster to existing tables/partitions is not synced to : another Impala cluster. : <p> : Only new tables and partitions are synced. : </p> : </li> > Hi Alex, Are you still working on this review? I didn't see this getting ad Sorry, I missed a few comments. Fixed those and uploading a new patch. http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@219 PS2, Line 219: <li> : Adding data from one Impala cluster to existing tables/partitions is not synced to : another Impala cluster. : <p> : Only new tables and partitions are synced. : </p> : </li> > This is not true anymore and can be removed removed http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@233 PS2, Line 233: Hive's > I think even Impala has a LOAD DATA command so we probably should mention t Removed "Hive's" http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@233 PS2, Line 233: recommend > nit, recommended Done http://gerrit.cloudera.org:8080/#/c/13300/2/docs/topics/impala_metadata.xml@263 PS2, Line 263: hive.metastore.dml.events > This particular config should be present in the HiveServer2's configuration Done -- To view, visit http://gerrit.cloudera.org:8080/13300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68133b0beeb15cacc73829b8a8b0838fc7f4b7d8 Gerrit-Change-Number: 13300 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Bharath Krishna <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2019 20:43:39 +0000 Gerrit-HasComments: Yes
