Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13333 )
Change subject: IMPALA-6903: Download profile from WebUI in text format ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/13333/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/13333/7/tests/webserver/test_web_pages.py@547 PS7, Line 547: test_download_text_profile do we have a test for the base64 encoded profile? http://gerrit.cloudera.org:8080/#/c/13333/7/tests/webserver/test_web_pages.py@560 PS7, Line 560: assert download_link in responses[0].text assert len(responses) == 1 -- To view, visit http://gerrit.cloudera.org:8080/13333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030c2bb330211f51840417b9f7880f19174af7b Gerrit-Change-Number: 13333 Gerrit-PatchSet: 7 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2019 18:53:51 +0000 Gerrit-HasComments: Yes
