Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13333 )
Change subject: IMPALA-6903: Download profile from WebUI in text format ...................................................................... Patch Set 8: (3 comments) submit a new patch http://gerrit.cloudera.org:8080/#/c/13333/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/13333/7/tests/webserver/test_web_pages.py@23 PS7, Line 23: import json > Should remove this Done http://gerrit.cloudera.org:8080/#/c/13333/7/tests/webserver/test_web_pages.py@547 PS7, Line 547: "Test download text profil > do we have a test for the base64 encoded profile? This one is related: test_query_profile_encoded_unknown_query_id http://gerrit.cloudera.org:8080/#/c/13333/7/tests/webserver/test_web_pages.py@560 PS7, Line 560: # Get the response from download link and > assert len(responses) == 1 Are you talking about line 557? Line 560 makes sure the download link is in the UI. -- To view, visit http://gerrit.cloudera.org:8080/13333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030c2bb330211f51840417b9f7880f19174af7b Gerrit-Change-Number: 13333 Gerrit-PatchSet: 8 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2019 20:38:52 +0000 Gerrit-HasComments: Yes
