Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/13313/10/shell/impala_shell_config_defaults.py File shell/impala_shell_config_defaults.py: http://gerrit.cloudera.org:8080/#/c/13313/10/shell/impala_shell_config_defaults.py@20 PS10, Line 20: # defaults for OptionParser options stored in dict nit: we'll need to update this since we are now storing a default not used by OptionParser http://gerrit.cloudera.org:8080/#/c/13313/10/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/13313/10/tests/shell/test_shell_commandline.py@479 PS10, Line 479: # @pytest.mark.execute_serially nit: remove comment http://gerrit.cloudera.org:8080/#/c/13313/10/tests/shell/test_shell_commandline.py@480 PS10, Line 480: def test_global_config_file(self, vector): I think we only need the following tests: - shell uses options and query options in global config - options and query options in global config get overridden by those in user config - options in global config get overridden by command line options - specified global config file does not exist Also add a test in test_query_option_configuration which verifies that query_options under [impala] override the query_options defined under [impala.query_options] -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 10 Gerrit-Owner: Ethan Xue <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Ethan Xue <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 25 May 2019 00:38:00 +0000 Gerrit-HasComments: Yes
