Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@479 PS12, Line 479: def test_global_config_file(s > Thanks for pointing that out, I looked into it and it seems like that was a Done http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@487 PS12, Line 487: "A valid config file should not trig > What are the cases where warnings would be triggered? If there is a case sp Done http://gerrit.cloudera.org:8080/#/c/13313/13/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/13313/13/tests/shell/test_shell_interactive.py@434 PS13, Line 434: V > nit: upper case Done -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 14 Gerrit-Owner: Ethan Xue <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Ethan Xue <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 21:27:29 +0000 Gerrit-HasComments: Yes
