Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 )
Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed ...................................................................... Patch Set 7: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/13306/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/13306/5/be/src/service/impala-server.cc@2127 PS5, Line 2127: } else { > Yeah it looks like the original intention was to adaptively set the sleep Doesn't seem necessary to tackle here - filing a JIRA seems worthwhile. http://gerrit.cloudera.org:8080/#/c/13306/7/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/13306/7/be/src/service/impala-server.cc@2155 PS7, Line 2155: >= FLAGS_disconnected_session_timeout * 1000) { It would be good to do the multiplication in 64 bits to avoid the possibility of overflow. E.g. could explicitly cast, or use a 1000L http://gerrit.cloudera.org:8080/#/c/13306/7/be/src/service/impala-server.cc@2158 PS7, Line 2158: DCHECK(session_state->session_type == TSessionType::HIVESERVER2); DCHECK_EQ or DCHECK_ENUM_EQ? http://gerrit.cloudera.org:8080/#/c/13306/7/be/src/service/impala-server.cc@2199 PS7, Line 2199: clsoed typo -- To view, visit http://gerrit.cloudera.org:8080/13306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4555cd9b73db5b4dde92cd4fac4f9bfa3664d78 Gerrit-Change-Number: 13306 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 16:16:01 +0000 Gerrit-HasComments: Yes
