Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 )
Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/13306/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13306/9//COMMIT_MSG@27 PS9, Line 27: disconnected_esession_timeout typo http://gerrit.cloudera.org:8080/#/c/13306/8/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: http://gerrit.cloudera.org:8080/#/c/13306/8/be/src/rpc/thrift-server.h@113 PS8, Line 113: cnotext context http://gerrit.cloudera.org:8080/#/c/13306/9/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/13306/9/be/src/service/impala-server.h@1030 PS9, Line 1030: if (ThriftServer::HasThreadConnectionContext()) { Can we put the body of this if() in a separate function in impala-hs2-server.cc? It's a bit much to have in this already-large header. E.g. ImpalaServer::AddConnectionToSession() http://gerrit.cloudera.org:8080/#/c/13306/9/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/13306/9/tests/common/impala_connection.py@280 PS9, Line 280: # The session may no longer be valid if the impalad was restarted during the test. LOG.exception() so we get the backtrace if needed for later debugging (I assume this would be fairly rare). -- To view, visit http://gerrit.cloudera.org:8080/13306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4555cd9b73db5b4dde92cd4fac4f9bfa3664d78 Gerrit-Change-Number: 13306 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 20:37:33 +0000 Gerrit-HasComments: Yes
