Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@479 PS12, Line 479: def test_global_config_file(s > we dont need this test to execute serially so you can remove it Removed it. Just curious why we don't need it though as the test below also tests config files and it runs serially. http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@483 PS12, Line 483: > this is not being verified Thanks, I added a verification. http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@487 PS12, Line 487: assert 'Query: select 2' in result.std > what is this verifying? This is verifying that a valid global impalarc file should not trigger any warnings in the shell. A similar verification is done for the user config. http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_interactive.py@434 PS12, Line 434: # verify that query options under [impala] override those under [impala.query_options] > nit: add a comment above this mentioning that you are verifying id the quer Done -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 13 Gerrit-Owner: Ethan Xue <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Ethan Xue <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 17:04:41 +0000 Gerrit-HasComments: Yes
