Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13487 )

Change subject: IMPALA-8425: part 1: reduce size of binaries in container
......................................................................


Patch Set 4:

For our test runs we would still have the unstripped binary available (I guess 
I hadn't confirmed that worked correctly). I don't know about the more general 
question of whether we want to optionally provide containers with the symbols 
built-in. It does seem like a lot of overhead to the size of the containers, 
and you would still have to extract the binary from the container to use it 
with GDB and a core file. It's nice that that would be an option though.

We still should have enough symbols to get backtraces as-is.


--
To view, visit http://gerrit.cloudera.org:8080/13487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95ff479bedd3b93e6569e72f03f42acd9dba8b14
Gerrit-Change-Number: 13487
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 05 Jun 2019 00:45:16 +0000
Gerrit-HasComments: No

Reply via email to