Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 )
Change subject: IMPALA-8425: part 1: reduce size of binaries in container ...................................................................... Patch Set 4: Code-Review+2 (1 comment) > For our test runs we would still have the unstripped binary > available (I guess I hadn't confirmed that worked correctly). I > don't know about the more general question of whether we want to > optionally provide containers with the symbols built-in. It does > seem like a lot of overhead to the size of the containers, and you > would still have to extract the binary from the container to use it > with GDB and a core file. It's nice that that would be an option > though. > > We still should have enough symbols to get backtraces as-is. That makes sense. In the test, we have the original binary, so at the end bin/jenkins/finalize.sh can resolve the minidumps. For things that end up in an actual deployment, we'll want to preserve the symbols or original binary somewhere, but that is not a new problem. The tests were the main thing I was concerned about. http://gerrit.cloudera.org:8080/#/c/13487/4/docker/impala_base/Dockerfile File docker/impala_base/Dockerfile: http://gerrit.cloudera.org:8080/#/c/13487/4/docker/impala_base/Dockerfile@30 PS4, Line 30: # Copy build artifacts required for the daemon processes. : # Need to have multiple copy commands to preserve directory structure. : COPY lib /opt/impala/lib : COPY www /opt/impala/www : COPY bin /opt/impala/bin : # Symlink here instead of in setup_build_context to avoid duplicate binaries. : RUN cd /opt/impala/bin && ln -s impalad statestored && ln -s impalad catalogd && \ : # Create conf directory for later config injection. : mkdir /opt/impala/conf && \ : # Create logs directory to collect container logs. : mkdir /opt/impala/logs > Yeah it does - after USER impala, the commands are run as the Impala user, I was thinking about the block of COPYs and the RUN that makes some directories and links executables. It moved from after USER impala to before. None of that impacts the review, they both seem correct. I'm just curious if there was anything going on under the covers. -- To view, visit http://gerrit.cloudera.org:8080/13487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95ff479bedd3b93e6569e72f03f42acd9dba8b14 Gerrit-Change-Number: 13487 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2019 16:43:02 +0000 Gerrit-HasComments: Yes
