Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13640 )
Change subject: IMPALA-8583: Add metrics for BASIC auth ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/13640/1/be/src/rpc/auth-provider.h File be/src/rpc/auth-provider.h: http://gerrit.cloudera.org:8080/#/c/13640/1/be/src/rpc/auth-provider.h@33 PS1, Line 33: AuthProvid > this doesn't seem right Done http://gerrit.cloudera.org:8080/#/c/13640/1/be/src/transport/THttpServer.h File be/src/transport/THttpServer.h: http://gerrit.cloudera.org:8080/#/c/13640/1/be/src/transport/THttpServer.h@84 PS1, Line 84: THttpSer > no need for explicit on multi-arg ctor Done http://gerrit.cloudera.org:8080/#/c/13640/1/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/13640/1/be/src/transport/THttpServer.cpp@152 PS1, Line 152: total_basic_auth_success_->Increment(1); > semi-related to this patch: do we do any logging of the incorrect login att Yes, we log a warning with the username and ldap error on all failed attempts, as well as having a variety of other logging around different sasl/kerberos errors, and some vlog-ing on successful attempts. http://gerrit.cloudera.org:8080/#/c/13640/1/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/13640/1/common/thrift/metrics.json@945 PS1, Line 945: Basic (use > in the long description perhaps we should say Basic (username/password) Aut Done http://gerrit.cloudera.org:8080/#/c/13640/1/common/thrift/metrics.json@949 PS1, Line 949: Basic > nit: BASIC isn't an acronym so I think it should just be capitalized as "Ba Done http://gerrit.cloudera.org:8080/#/c/13640/1/common/thrift/metrics.json@955 PS1, Line 955: auth > similar to above, maybe say something like "due to an invalid username and Done -- To view, visit http://gerrit.cloudera.org:8080/13640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d1b1bcc093e4b00802bc108ff4d8d4e2cdfd88f Gerrit-Change-Number: 13640 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 13 Jun 2019 23:24:42 +0000 Gerrit-HasComments: Yes
