Hello Todd Lipcon, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13640

to look at the new patch set (#3).

Change subject: IMPALA-8583: Add metrics for Basic auth
......................................................................

IMPALA-8583: Add metrics for Basic auth

The patch adds two metrics:
impala.thrift-server.hiveserver2-http-frontend.total-basic-auth-success
impala.thrift-server.hiveserver2-http-frontend.total-basic-auth-failure
which track the number of successful and failed attempts at using
Basic auth to authentication to the hiveserver2 http server.

A followup patch will add similar metrics for SASL attempts on the
beeswax and hiveserver2 binary servers.

Testing:
- Modified existing HTTP auth test to check that the produced metrics
  are correct.

Change-Id: I6d1b1bcc093e4b00802bc108ff4d8d4e2cdfd88f
---
M be/src/rpc/auth-provider.h
M be/src/rpc/authentication.cc
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/transport/THttpServer.cpp
M be/src/transport/THttpServer.h
M common/thrift/metrics.json
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
8 files changed, 111 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/13640/3
--
To view, visit http://gerrit.cloudera.org:8080/13640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d1b1bcc093e4b00802bc108ff4d8d4e2cdfd88f
Gerrit-Change-Number: 13640
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to