Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13690 )
Change subject: IMPALA-8652 Illegal delimiter error in shell has unknown error ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13690/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/13690/1/shell/impala_shell.py@1733 PS1, Line 1733: if options.output_delimiter != "\\t": Can we not check if the delimiter is not empty then perform the validation? http://gerrit.cloudera.org:8080/#/c/13690/1/shell/impala_shell.py@1738 PS1, Line 1738: sys.exit(1) Raise FatalShellException to be consistent with the rest of the code here. Can we also add/update the test to catch this issue? -- To view, visit http://gerrit.cloudera.org:8080/13690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ee2fccd305b104b3aff44c57659b6f14f2f4a05 Gerrit-Change-Number: 13690 Gerrit-PatchSet: 1 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Jun 2019 20:24:48 +0000 Gerrit-HasComments: Yes
