Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13690 )
Change subject: IMPALA-8652 Illegal delimiter error in shell has unknown error ...................................................................... Patch Set 2: (2 comments) A couple of minor nits, then looks good to go. http://gerrit.cloudera.org:8080/#/c/13690/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13690/2//COMMIT_MSG@19 PS2, Line 19: tests/shell/test_shell_commandline.py passed Can you include an example of what the new output looks like? Just to illustrate that the issue is fixed. http://gerrit.cloudera.org:8080/#/c/13690/2/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/13690/2/shell/shell_output.py@54 PS2, Line 54: self.field_delim = field_delim.decode('string-escape') I'd suggest adding an assert here, just to document and check the assumption that the delimiter was validated elsewhere, i.e. assert len(self.field_delim) != 1 -- To view, visit http://gerrit.cloudera.org:8080/13690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ee2fccd305b104b3aff44c57659b6f14f2f4a05 Gerrit-Change-Number: 13690 Gerrit-PatchSet: 2 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Jun 2019 22:06:40 +0000 Gerrit-HasComments: Yes
