Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13680 )
Change subject: IMPALA-8665 Include extra info in error message when date cast fails ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13680/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13680/4//COMMIT_MSG@9 PS4, Line 9: When users cast string to date. It's hard for users to debug right now : if users running millions of rows casting while casting failed without : extra information. : : Solution: : Add the failed data value into error message. The description is a bit confusing. How about: "This change extends the error message Impala yields when casting STRING to DATE (explicitly or implicitly) fails. The new error message includes the violating string value." http://gerrit.cloudera.org:8080/#/c/13680/4//COMMIT_MSG@20 PS4, Line 20: Examples Typo: Example http://gerrit.cloudera.org:8080/#/c/13680/4//COMMIT_MSG@21 PS4, Line 21: select ("2000" as Date); select cast('2000' as date); -- To view, visit http://gerrit.cloudera.org:8080/13680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04 Gerrit-Change-Number: 13680 Gerrit-PatchSet: 4 Gerrit-Owner: Jiawei Wang <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiawei Wang <[email protected]> Gerrit-Comment-Date: Mon, 24 Jun 2019 15:14:12 +0000 Gerrit-HasComments: Yes
