Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13680 )
Change subject: IMPALA-8665 Include extra info in error message when date cast fails ...................................................................... Patch Set 7: (3 comments) Thank you! I have few more nit-picky comments before we can merge this in: http://gerrit.cloudera.org:8080/#/c/13680/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13680/7//COMMIT_MSG@7 PS7, Line 7: IMPALA-8665 nit: In the change title, the JIRA number should be followed with a colon or dot character. "IMPALA-8665: " instead of "IMPALA-8665 " I know it is silly, but these are the rules :) http://gerrit.cloudera.org:8080/#/c/13680/7//COMMIT_MSG@19 PS7, Line 19: ERROR: UDF ERROR: String to Date parse failed. Invalid string val: "2000" nit: long line. Lines in the Commit Message should wrap at 72 characters. http://gerrit.cloudera.org:8080/#/c/13680/7/be/src/exprs/cast-functions-ir.cc File be/src/exprs/cast-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/13680/7/be/src/exprs/cast-functions-ir.cc@312 PS7, Line 312: char* stringVal = reinterpret_cast<char*>(val.ptr); 'val' is a const reference, so probably it's be best to keep val.ptr's constness: const char* stringVal = reinterpret_cast<const char*>(val.ptr); -- To view, visit http://gerrit.cloudera.org:8080/13680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If800b7696515cd61afee27220c55ff2440a86f04 Gerrit-Change-Number: 13680 Gerrit-PatchSet: 7 Gerrit-Owner: Jiawei Wang <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiawei Wang <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2019 16:15:11 +0000 Gerrit-HasComments: Yes
