Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13765 )
Change subject: IMPALA-8718: Fixed AnalysisException in inline view with outer join complex type column ...................................................................... Patch Set 3: (6 comments) Still trying to understand the overall approach here. The commit message seems to indicate that the NULL check is not necessary for complex types, but I don't really understand why; plus the JIRA description in IMPALA-8718 seems to indicate the NULL check is necessary. http://gerrit.cloudera.org:8080/#/c/13765/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13765/3//COMMIT_MSG@11 PS3, Line 11: make right side exprs nullable, it makes a wrapper nit: what is "it", the Impala planner? http://gerrit.cloudera.org:8080/#/c/13765/3//COMMIT_MSG@16 PS3, Line 16: cannot both be null and non-null. But during its This line is a bit confusing. Can you clarify what you mean here? http://gerrit.cloudera.org:8080/#/c/13765/3//COMMIT_MSG@17 PS3, Line 17: checking whether the wrapper needed, because of code what do you mean by "because of code limitation"? http://gerrit.cloudera.org:8080/#/c/13765/3/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test File testdata/workloads/functional-query/queries/QueryTest/complex_joins.test: http://gerrit.cloudera.org:8080/#/c/13765/3/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test@5 PS3, Line 5: create table array_tbl (col1 string, col2 array <string>) stored as parquet; databases such as "functional_parquet" already have tables such as "complextypestbl" that you can use. See "test_nested_types.py" for examples. http://gerrit.cloudera.org:8080/#/c/13765/3/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test@35 PS3, Line 35: select t.col1, rank() over(order by t.col1) as rnk is the analytical function necessary to re-produce the error? otherwise I think it is just adding unnecessary complexity to the test case. http://gerrit.cloudera.org:8080/#/c/13765/3/tests/query_test/test_complex.py File tests/query_test/test_complex.py: http://gerrit.cloudera.org:8080/#/c/13765/3/tests/query_test/test_complex.py@23 PS3, Line 23: class TestComplex(ImpalaTestSuite): You can just add this test to test_nested_types.py instead of creating a new file. I think the pattern in the Impala codebase is to refer to array, map, and struct types as "nested" types, rather than "complex" types. -- To view, visit http://gerrit.cloudera.org:8080/13765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida65503ca4b1342b8fe0049753bc664da227dca9 Gerrit-Change-Number: 13765 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 15:55:31 +0000 Gerrit-HasComments: Yes
