Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13765 )
Change subject: IMPALA-8718: Fixed AnalysisException in inline view with outer join complex type column ...................................................................... Patch Set 3: (5 comments) Answer Sahil's question: IsNull Check may be necessary for other places, but use IsNullPredicate in requiresNullWrapping is not required. We can workaround it. Attach patch 4 with fixed tests. Run all core tests. http://gerrit.cloudera.org:8080/#/c/13765/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13765/3//COMMIT_MSG@16 PS3, Line 16: cannot both be null and non-null. But during its > This line is a bit confusing. Can you clarify what you mean here? Although we do not have the predict to tell if a value is null, we know that a valid should be either null or nonnull and cannot be both. http://gerrit.cloudera.org:8080/#/c/13765/3//COMMIT_MSG@17 PS3, Line 17: checking whether the wrapper needed, because of code > what do you mean by "because of code limitation"? We do not have IsNullPredicate for complex type, it is mentioned in the latter part of the message. I will make a change to add it here too. http://gerrit.cloudera.org:8080/#/c/13765/3/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test File testdata/workloads/functional-query/queries/QueryTest/complex_joins.test: http://gerrit.cloudera.org:8080/#/c/13765/3/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test@5 PS3, Line 5: create table array_tbl (col1 string, col2 array <string>) stored as parquet; > databases such as "functional_parquet" already have tables such as "complex This is the test case that the customer provided. And our functional table does not have data. http://gerrit.cloudera.org:8080/#/c/13765/3/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test@35 PS3, Line 35: select t.col1, rank() over(order by t.col1) as rnk > is the analytical function necessary to re-produce the error? otherwise I t Yes, it is the customer's case, I must make sure the tests passed with/without data. Why create two: The testing framework parallels the tests which make test flaky if switching between impala and hive. http://gerrit.cloudera.org:8080/#/c/13765/3/tests/query_test/test_complex.py File tests/query_test/test_complex.py: http://gerrit.cloudera.org:8080/#/c/13765/3/tests/query_test/test_complex.py@23 PS3, Line 23: class TestComplex(ImpalaTestSuite): > You can just add this test to test_nested_types.py instead of creating a ne I will move -- To view, visit http://gerrit.cloudera.org:8080/13765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida65503ca4b1342b8fe0049753bc664da227dca9 Gerrit-Change-Number: 13765 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Jul 2019 09:11:42 +0000 Gerrit-HasComments: Yes
