Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13785 )
Change subject: IMPALA-8734: Reload table schema on TBLPROPERTIES change ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13785/3/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/13785/3/tests/metadata/test_ddl.py@697 PS3, Line 697: self.execute_query_expect_success(self.client, "create table {0}.{1} (c1 string)" > Is there a reason for not creating a new test? The new code seems to be com No reason, I thought it would be simpler, but yeah it seems creating a new test is better. Done. http://gerrit.cloudera.org:8080/#/c/13785/3/tests/metadata/test_ddl.py@702 PS3, Line 702: ct_s > Using a less "null like" value could make the test's intention clearer - it I was following the test case, but yeah using a different value is more readable. Done. http://gerrit.cloudera.org:8080/#/c/13785/3/tests/metadata/test_ddl.py@701 PS3, Line 701: file_data="\nfoo\n") : self.execute_query_expect_success(self.client, : "alter table {0}.{1} set tblproperties" : "('serialization.null.format'='foo')" : .format(unique_database, tbl_name)) : result = self.execute_query_expect_success(self.client, : "select * from {0}.{1}" : .format(unique_database, tbl_name)) : assert len(result.data) == 2 : assert result.data[0] == '' > First I thought that it would be nice to create a utility function for this TIL. Done. -- To view, visit http://gerrit.cloudera.org:8080/13785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a43a962c2a456f3ddc078b2924f551fccb5c2ad Gerrit-Change-Number: 13785 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 19:52:12 +0000 Gerrit-HasComments: Yes
