Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13790 )
Change subject: IMPALA-8543: More diagnostics for TAcceptQueueServer ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13790/1/be/src/rpc/TAcceptQueueServer.h File be/src/rpc/TAcceptQueueServer.h: http://gerrit.cloudera.org:8080/#/c/13790/1/be/src/rpc/TAcceptQueueServer.h@119 PS1, Line 119: cnxns_setup_time_metric_ cnxns_setup_time_us_metric_ or note the units in the comment http://gerrit.cloudera.org:8080/#/c/13790/1/be/src/rpc/TAcceptQueueServer.cpp File be/src/rpc/TAcceptQueueServer.cpp: http://gerrit.cloudera.org:8080/#/c/13790/1/be/src/rpc/TAcceptQueueServer.cpp@255 PS1, Line 255: timer.Reset(); Maybe make this two separate variables, eg. setup_timer and thread_wait_timer, or at least leave a comment here and at the call to Start() eg: // Start timing for connection setup // Start timing for getting the service thread http://gerrit.cloudera.org:8080/#/c/13790/1/be/src/rpc/TAcceptQueueServer.cpp@293 PS1, Line 293: string Can this one also be made const? http://gerrit.cloudera.org:8080/#/c/13790/1/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/13790/1/common/thrift/metrics.json@955 PS1, Line 955: connection client connection? here and elsewhere -- To view, visit http://gerrit.cloudera.org:8080/13790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33b32352b457a2c8ec7bae6da46bb9c555dc9c36 Gerrit-Change-Number: 13790 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 08 Jul 2019 19:57:08 +0000 Gerrit-HasComments: Yes
