Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13790 )
Change subject: IMPALA-8543: More diagnostics for TAcceptQueueServer ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13790/1/be/src/rpc/TAcceptQueueServer.cpp File be/src/rpc/TAcceptQueueServer.cpp: http://gerrit.cloudera.org:8080/#/c/13790/1/be/src/rpc/TAcceptQueueServer.cpp@406 PS1, Line 406: 5 * 60 * MICROS_PER_SEC, 1 maybe label these, eg: /* highest_trackable_value */ http://gerrit.cloudera.org:8080/#/c/13790/1/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/13790/1/common/thrift/metrics.json@955 PS1, Line 955: connection > client connection? here and elsewhere In fact, rather than having the label always match the description on these, it might be helpful to be a little more explicit, eg: "Stats on the amount of time client connections to the Beeswax API spend waiting for the connection to be setup" or similar -- To view, visit http://gerrit.cloudera.org:8080/13790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33b32352b457a2c8ec7bae6da46bb9c555dc9c36 Gerrit-Change-Number: 13790 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2019 00:18:24 +0000 Gerrit-HasComments: Yes
