Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 )
Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/coordinator-backend-state.cc@200 PS1, Line 200: sidecar.__set_query_ctx(query_ctx()); > Makes me wonder if we should factor out the descriptor table from query_ctx After reading the code some more, the entire query_ctx() is shared across all executors, so we should be able to put that into its own sidecar. There is some code that relies on being able to read the thrift structures directly (e.g. RpcMgr::DoRpcWithRetry(), which is called from Coordinator::BackendState::Cancel()). I'm looking into whether there is a simpler fix that just serializes TQueryCtx. The DescriptorTable is definitely the piece that can grow largest. -- To view, visit http://gerrit.cloudera.org:8080/13772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I458aa62dd4d1e4e4a7b1869a604623a69f3b2d9a Gerrit-Change-Number: 13772 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2019 00:59:27 +0000 Gerrit-HasComments: Yes
