Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 )
Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx ...................................................................... Patch Set 2: (2 comments) After looking into serializing the whole TQueryCtx (which is the same across all the backends), I decided that this would be harder to backport. I filed IMPALA-8749 to track that. Fixing that JIRA may end up undoing some of this fix. http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/descriptors.h File be/src/runtime/descriptors.h: http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/descriptors.h@480 PS1, Line 480: thrift_tbl > stale Fixed description http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/descriptors.h@485 PS1, Line 485: thrift_tbl > stale Fixed this and renamed the one that takes regular Thrift to CreateInternal() and made it private (with friend classes for the two places that actually use it). -- To view, visit http://gerrit.cloudera.org:8080/13772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I458aa62dd4d1e4e4a7b1869a604623a69f3b2d9a Gerrit-Change-Number: 13772 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2019 21:43:08 +0000 Gerrit-HasComments: Yes
