Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115 PS4, Line 2115: This : operation is not supported in Kudu that is integrated with Hive : Metastore. I don't think that this is correct. The design doc says that this applies to "orphaned" tables, i.e. Kudu tables that existed in Impala before HMS integration was turned on and haven't been updated with the fix tool. However, I don't think this is actually being enforced, both from looking at it experimentally and from looking through the code. Could someone from the Kudu team confirm my understanding here? http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml File docs/topics/impala_kudu.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116 PS4, Line 1116: <note>This section only applies the Kudu services that are not This patch mostly just points out things that no longer apply. Is there an intention to add a section about how the new integration works or how to do the upgrade? http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml File docs/topics/impala_tables.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336 PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix Maybe move this up to be directly after the paragraph that talks about '::' above -- To view, visit http://gerrit.cloudera.org:8080/13776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e Gerrit-Change-Number: 13776 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Jul 2019 19:04:13 +0000 Gerrit-HasComments: Yes